norlab-ulaval / norlab_icp_mapper

A 2-D/3-D mapping library relying on the "Iterative Closest Point" algorithm
https://norlab-icp-mapper.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
60 stars 15 forks source link

Update libpointmatcher required version #18

Closed fdila closed 3 months ago

fdila commented 3 months ago

Hi! I've noticed that the libpointmatcher version specified in the CMakeLists does not match the actual requirements of norlab_icp_mapper. Actually, there is no "official" libpointmatcher version that is compatible with this repo, I switched to the "develop" branch of libpointmatcher to make icp_mapper compile. It would be nice to specify it in the readme, or release a new version of libpointmatcher and update the CMake requirements.

boxanm commented 3 months ago

Hi @fdila. thanks for noticing this issue! It is something we missed when stabilizing the mapper. I'll make a new libpointmatcher release reflecting the changes soon and will ping you here once it's done.

boxanm commented 3 months ago

Hi @fdila , a new libpointmatcher version 1.4.3 was released, you can now use the mapper with this tag.