norlab-ulaval / percep3d_lessons

10 stars 5 forks source link

fixed typo in translation matrix #23

Closed marcmorin99 closed 2 years ago

marcmorin99 commented 3 years ago

Was missing two "1" on the diagonal.

marcmorin99 commented 3 years ago

I will review the rest of this part since there seems to be an invalid order of the matrices also.

pomerlef commented 3 years ago

You can keep it open and add your commit to the same PR.

I confirm for the first typo, good catch!

marcmorin99 commented 3 years ago

Thanks, I think everything is fine now!

pomerlef commented 3 years ago

Yes, I confirm the second correction. Thanks @marcmorin99 !