search

norlab-ulaval / percep3d_lessons

10 stars 5 forks source link

Wrong helper function imported in SE(3) exercises #36

Open amoreau96 opened 2 years ago

amoreau96 commented 2 years ago

In SE(3) exercises, the imported helper_func.py is from the transformation_2d lessons.

I assume this is because the students might want to use some of its functions for the first exercise. Won't it crash when you try to run the exercises from the student's zip file, since the 2D helper_func.py isn't included in the zip file?

Apologies in advance if this is the desired behavior.

pomerlef commented 2 years ago

Thanks, we will investigate that. It could be from a wrong copy-paste.

I would add that, having multiple files named helper_func.py is not the best for maintenance. We should be more explicit for these file names.