search

normal-computing / posteriors

Uncertainty quantification with PyTorch
https://normal-computing.github.io/posteriors/
Apache License 2.0
282 stars 12 forks source link

Ensure inplace defaults to False #97

Closed SamDuffield closed 1 month ago

SamDuffield commented 1 month ago

Just unifying the defaults for torchopt and laplace.dense_fisher

farice commented 1 month ago

Nvm it's just defaults

SamDuffield commented 1 month ago

Any tests to demonstrate effects?

There are already tests for both inplace=True and inplace=False, this simply unifies the default behaviour.

We don't currently explicitly test default behaviour, although this could be interesting to scope out for a future PR 😎