Send ACK / NACK bytes for slcan

normaldotcom / canable-fw

Firmware for the CANable USB to CAN adapter

http://canable.io/

Other

184 stars 72 forks source link

Open normaldotcom opened 5 years ago

normaldotcom commented 5 years ago

This would add support for UAVCAN operation

normaldotcom commented 5 years ago

Added support, currently commented out. Enabling causes lockup during rx/tx; need to debug.

pklapperich commented 1 year ago

We've been using this for with ACK/NACK enabled for the last year. I think maybe the commits in 2021 fixed the lockup issue.

The commented code is:

// Success
//if(result == 0)
//    CDC_Transmit_FS("\n", 1);
// Failure
//else
//    CDC_Transmit_FS("\a", 1);

In addition to uncommenting it, we had to change the ACK from \n to \r to make it work with pyuavcan and pydronecan.