support Rails 5, due to https://github.com/drapergem/draper/issues/697

norman / ambry

Ambry is a database and ORM replacement for (mostly) static models and small datasets. It provides ActiveModel compatibility, and flexible searching and storage.

http://rubydoc.info/github/norman/ambry/master/frames

MIT License

57 stars 3 forks source link

support Rails 5, due to https://github.com/drapergem/draper/issues/697 #16

Closed qazbnm456 closed 8 years ago

qazbnm456 commented 8 years ago

As titled, active_model/serializers/xml has been removed in Rails 5, and extracted into its own gem.

However, there is not yet a published release of activemodel-serializers-xml so far.

zokioki commented 8 years ago

Version 1.0.0 of activemodel-serializers-xml has been recently published. :)

tute commented 8 years ago

aha, but this is a backwards incompatible change now. Merit has been successfully using ambry in production projects for years now. I think we can do a version 1 release. What do you think, @norman? With this fix, needed for https://github.com/merit-gem/merit/issues/258.

We can also simplify the CI build matrix, and I'm not sure if there is code that can go as well, in such a change.

tute commented 8 years ago

Opened a PR dropping support for the XML serializer in https://github.com/norman/ambry/pull/17. What do you think?

tute commented 8 years ago

Merged in the update with no XML support. Thank you for your contribution!