search

norman / friendly_id-globalize

Globalize support for FriendlyId
MIT License
66 stars 32 forks source link

Create RubyGems release for 1.0.0.alpha4 #30

Open benjaminwil opened 4 years ago

benjaminwil commented 4 years ago

Hello!

This issue is just a request for an update to the gem distributed at RubyGems.

In my project I use friendly_id-globalize at 1.0.0.alpha3. After upgrading to Rails 5.2 I am getting many of the following warning:

DEPRECATION WARNING: Dangerous query method (method whose arguments 
  are used as raw SQL) called with non-attribute argument(s): 
  "\"friendly_id_slugs\".id DESC".  

  Non-attribute arguments will be disallowed in Rails 6.0. This method should
  not be called with user-provided values, such as request parameters or model
  attributes. Known-safe values can be passed by wrapping them in Arel.sql().

I see this issue was already fixed in #26.

I'm happy to explicitly install the gem using the master ref instead of the RubyGems version in the meantime.

Thanks for your work on this gem and globalize!

wbotelhos commented 3 years ago

Hi @norman ,

Could you please upload the alpha4 version? This version was set in 2018 and would be great if you could push the gem to RubyGems.

Thank you!

mateuszgorniak commented 6 months ago

Hi, could anyone release the latest changes? :-) Unfortunately I'm not able to use it now after upgrading Ruby version as the mentioned release is not pushed.

mateuszgorniak commented 2 weeks ago

Any update here or any problems with releasing this new version I can support with? It's a bit shame changes implemented by @parndt are not easily accessible now 😢

parndt commented 1 week ago

@mateuszgorniak does it work for you if I push the current code in 097eed19e9d2f6bbf5ee7636493c03f7025d813b as 1.0.0.alpha4?

1.0.0.alpha4 was never tagged, the version file was updated so that it would be the next version

mateuszgorniak commented 1 week ago

Yep, it would be awesome @parndt! 🫶