search

norman / friendly_id

FriendlyId is the “Swiss Army bulldozer” of slugging and permalink plugins for ActiveRecord. It allows you to create pretty URL’s and work with human-friendly strings as if they were numeric ids for ActiveRecord models.
http://norman.github.io/friendly_id/
MIT License
6.13k stars 589 forks source link

Fix issues with `allow_nil: true` #997

Closed joemsak closed 2 years ago

joemsak commented 2 years ago

Turns out, the documentation I added in #995 wasn't 100% accurate. I had to add tests for such examples and improve the internal code to support the option. This should now provide the fully expected behavior.

joemsak commented 2 years ago

@parndt I missed some necessary changes, this should resolve that.

joemsak commented 2 years ago

Dearest @parndt what is the likelihood of this getting merged and then a release? 🙏This PR satisfies the documentation. Let me know if you have feedback. Thanks!

parndt commented 2 years ago

@joemsak I have been thinking about this change on and off all week! I've added a suggestion, let me know what you think

parndt commented 2 years ago

I also spotted a duplicate raise which I've removed

joemsak commented 2 years ago

Thank you!

joemsak commented 1 year ago

Hey @parndt any chance on this making it to a release? Let me know your thoughts, thanks!

parndt commented 1 year ago

@joemsak yes, definitely, I will get to it as soon as I can. 😄

parndt commented 1 year ago

Version 5.5.0 pushed @joemsak