search

normen / homebridge-landroid

Homebridge plugin to control Worx Landroid robo mowers through the Worx Cloud
24 stars 8 forks source link

PartyMode switch now reacts properly to state from CloudConnector (Issue: #53) #57

Closed DennisJohnsen closed 1 year ago

DennisJohnsen commented 1 year ago

After a bunch of ´console.log()´ later, i managed to figure out the data was perfectly fine, but since its object.val was false when disabled, it would not be passed into the data for the plugin to consume. Simply adding a null and undefined check made it work.

Only issue i still see, is that the Homekit switch is waiting for response from the CloudConnector when making a change. This is causing the Plugin (or switch) to show up as "No response". But the correct information is still being sent back and forth.

DennisJohnsen commented 1 year ago

Issue: https://github.com/normen/homebridge-landroid/issues/53

normen commented 1 year ago

Duh, yeah thats a good reason. The waiting for the cloud connector is funny though, the plugin should only report its local data, really.. I guess its time to rip out those getters - they're not needed, the state of HomeKit itself is changed with the updateValue() call anyway. Although they all just read local values and report them.

Anyway, thanks for this!

normen commented 1 year ago

Can you remove the "dev" script before I merge?

normen commented 1 year ago

Eh, whatever ;)