search

nornagon / electron-minidump

Symbolicate Electron minidumps
51 stars 15 forks source link

macOS support #1

Closed TonyWuu closed 4 years ago

TonyWuu commented 4 years ago

Hey @nornagon! Any reason this is hardcoded for win32 platform?

const electronMinidump = async (options) => {
  const {version, quiet, force, file} = options
  const platform = 'win32'

Just curious because I swapped it with darwin and it seems to work fine for MacOS minidumps.

Also, is this meant to serve as a replacement for symbolicate-mac?

nornagon commented 4 years ago

This is not a replacement for symbolicate-mac. That repo works on textual dumps, such as those provided in macOS system crash reports or samples from Activity Monitor. This repo works on minidumps.

This repo should be generalized to work for non-windows platforms. I have some of that change locally on a machine I don't currently have access to due to COVID-19 😭

nornagon commented 4 years ago

I'll reopen this as this tool still doesn't work on non-windows minidumps without modification.

TonyWuu commented 4 years ago

Thanks @nornagon. Off the top of your head, other than the changes I mentioned above, is there anything else that needs to be done to get this working for MacOS only? Seems to be working for me, unless I'm missing something.

nornagon commented 4 years ago

Well, it needs to be parameterized for platform, and should support all the platforms and architectures that Electron supports: darwin {x64}, mas {x64}, linux {arm64,armv7l,ia32,x64}, win32 {arm64,ia32,x64}. Besides the command-line argument parsing needed to expose those options, the rest of the code should work fine once the correct symbols are downloaded.