search

nornagon / electron-minidump

Symbolicate Electron minidumps
51 stars 14 forks source link

parameterize for other platforms #2

Closed TonyWuu closed 4 years ago

TonyWuu commented 4 years ago

Support other platforms https://github.com/nornagon/electron-minidump/issues/1

I didn't add any validation that the right combination of platform + arch was used. I assume the error that electron-download throws is enough ¯_(ツ)_/¯

nornagon commented 4 years ago

Oh goodness, I didn't see this PR but I implemented basically the exact same thing. I'm going to close this, but I've effectively merged it and published as v2.0.0.

Thanks for the PR! Sorry I didn't see it sooner 😞