search

nornir-automation / nornir

Pluggable multi-threaded framework with inventory management to help operate collections of devices
https://nornir.readthedocs.io/
Apache License 2.0
1.4k stars 237 forks source link

evaluate codacy #150

Closed dbarrosop closed 5 years ago

dbarrosop commented 6 years ago

Provides both static analysis and coverage. Might be interesting.

dbarrosop commented 6 years ago

Alternatively switch to pylint from pylama

ktbyers commented 6 years ago

@dbarrosop pylint does find some things that are useful (that are current linters aren't catching) like when you accidentally use a built-in.

There is a bunch of garbage we in pylint we would have to turn off, but that should be easy.

codacy is new to me, but open to trying it.

ogenstad commented 6 years ago

Aren't both of those a thing that just gives you a grade? Can't we enable both of them and see what they say and then choose based on that?

dbarrosop commented 6 years ago

pylint does find some things that are useful (that are current linters aren't catching) like when you accidentally use a built-in.

I agree, I realized thanks to pylint I have been making the mistake of using vars as an argument for various functions :(

Aren't both of those a thing that just gives you a grade? Can't we enable both of them and see what they say and then choose based on that?

codacy basically uses pylint under the hoods so I'd suggest toying with pylint first and then we decide about codacy.