Closed ubaumann closed 2 years ago
Re-running isn't going to achieve anything, problem seems to be that github is phasing out python 3.6, which is understandable as py3.6 is EOL.
I totally understand if they remove 3.6 but in the documantation it is still listet: https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#python
I "re-run" the the actoin in my fork 3 days ago and it seams to work just fine: https://github.com/ubaumann/nornir/actions/runs/1803144103
Also in my fork I testet to exclude 3.6 on Windows https://github.com/ubaumann/nornir/pull/3/files but it would be easier to remove python 3.6 support.
What would you like to do? I am happy to make a PR
The error says it is not available:
https://github.com/nornir-automation/nornir/runs/5097222304?check_suite_focus=true#step:3:6
I looked a bit more into this and looks like we are using windows 2022, which doesn't have it:
https://github.com/actions/virtual-environments/blob/main/images/win/Windows2022-Readme.md#python
So I think what happened is that we use windows-latest
as the platform and gh probably change this to 2022 recently.
I think we should deprecate py3.6 as it is EOL, probably add 3.10 instead. I am going to ping @ktbyers before we go down that path in case he has strong opinions against it. If we deprecate py3.6 we should change it here too.
Yep sounds good to deprecate 3.6
Kirk
On Wed, Feb 9, 2022 at 5:07 AM David Barroso @.***> wrote:
The error says it is not available:
https://github.com/nornir-automation/nornir/runs/5097222304?check_suite_focus=true#step:3:6
I look a bit more onto it and looks like we are using windows 2022, which doesn't have it:
https://github.com/actions/virtual-environments/blob/main/images/win/Windows2022-Readme.md#python
So I think what happened is that we use windows-latest as the platform and gh probably change this to 2022 recently.
I think we should deprecate py3.6 as it is EOL, probably add 3.10 instead. I am going to ping @ktbyers https://github.com/ktbyers before we go down that path in case he has strong opinions against it. If we deprecate py3.6 we should change it here https://github.com/nornir-automation/nornir/blob/develop/pyproject.toml too.
— Reply to this email directly, view it on GitHub https://github.com/nornir-automation/nornir/issues/773#issuecomment-1033742154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG3VBBDH444GHKG2N3OCU3U2JRJNANCNFSM5NVYUFXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
-- Kirk Byers @.*** Simplify through Automation
Great! @ubaumann do you want to open a PR?
I am sorry I missed the last comment. I will make the PR :)
Created the PR https://github.com/nornir-automation/nornir/pull/780
No worries, and great work with that PR.
Solved by #780
The last GitHub Actions failed with the error
Version 3.6 with arch x64 not found
even if it should work. https://github.com/nornir-automation/nornir/runs/5062733087?check_suite_focus=true#logs I run the test in my fork and everyting works well so I guess a simple "Re-run all jobs" should do the trick.