search

nornir-automation / nornir

Pluggable multi-threaded framework with inventory management to help operate collections of devices
https://nornir.readthedocs.io/
Apache License 2.0
1.38k stars 234 forks source link

Fix pylama breakage (pep8 reference no longer works) #836

Closed ktbyers closed 1 year ago

ktbyers commented 1 year ago

It came to my attention on both the NAPALM and Netmiko repositories that pylama . no longer worked (for calling the linter).

Basically 'pycodestyle (pep8)' was no longer executed and it would just silently pass (even when you had linting issues). This update should fix this.

ktbyers commented 1 year ago

The W503 linting exclusion was causing linting issues (where what black would correct to would actually fail the linter):

https://stackoverflow.com/questions/57074300/what-is-the-recommended-way-to-break-a-long-if-statement-w504-line-break-after?rq=1

It looked like pycodestyle would always fail regardless of the form I used with either a W503 or a W504 error...so I just chose the one that black used (and disabled the other one).

ktbyers commented 1 year ago

@dbarrosop Can you disable this in GH settings (at least until someone fixes its failures):

CodeQL Expected — Waiting for status to be reported

I don't have access to settings for the Nornir repository (or I would disable it).

Thanks.

dbarrosop commented 1 year ago

Can you disable this in GH settings (at least until someone fixes its failures):

Done.

I don't have access to settings for the Nornir repository (or I would disable it).

Made you owner of the full org so you should have access to the whole thing now.