search

nornir-automation / nornir

Pluggable multi-threaded framework with inventory management to help operate collections of devices
https://nornir.readthedocs.io/
Apache License 2.0
1.37k stars 233 forks source link

add isort to manage/sort imports #864

Closed nemith closed 11 months ago

nemith commented 11 months ago

Add isort as a way to cleanup and manage imports in addition to black.

Black is great tool and will format the import lines, but doesn't sort them, remove unused imports, or sorts them but it does work well with the isort (import sort) tool.

https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#isort

Black was developed by Łukasz which at facebook and there we always used black along side isort as well.

See https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#isort

dbarrosop commented 11 months ago

This is fine by me, I am all for delegating as many opinions as possible to intransigent machines so if Kirk is fine with this too we can merge after the conflicts has been resolved.

ktbyers commented 11 months ago

Sounds good to me.

ktbyers commented 11 months ago

Replaced by:

https://github.com/nornir-automation/nornir/pull/873

It was easier to just redo the PR than to fix the conflicts.