Fix Sphinx add custom css issue

nornir-automation / nornir

Pluggable multi-threaded framework with inventory management to help operate collections of devices

https://nornir.readthedocs.io/

Apache License 2.0

1.39k stars 235 forks source link

Fix Sphinx add custom css issue #933

Closed ubaumann closed 3 months ago

ubaumann commented 3 months ago

Fixes #932

I resolved the issue with the sphinx build and removed the need for the sphinx make command, as there is already a docs command available.

ogenstad commented 3 months ago

LGTM, added some comments around the warnings here: https://github.com/nornir-automation/nornir/issues/932#issuecomment-2195572378

I do think it would be good if we could get the builds to start to run on the main branch too, it doesn't have to be done before this is merged but would be nice.

ktbyers commented 3 months ago

Okay, it looks like we will need @dbarrosop to fire off a readthedocs build to make sure this is working now.