Replace pkg_resources with importlib.metadata - Githubissues

nornir-automation / nornir

Pluggable multi-threaded framework with inventory management to help operate collections of devices

https://nornir.readthedocs.io/

Apache License 2.0

1.38k stars 234 forks source link

Replace pkg_resources with importlib.metadata #971

Closed ubaumann closed 2 weeks ago

ubaumann commented 3 weeks ago

pkg_resources is deprecated in Python 3.12 (https://setuptools.pypa.io/en/latest/pkg_resources.html), and importlib.metadata is available since Python 3.8 (https://docs.python.org/3.12/library/importlib.metadata.html)

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 10537096526

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.813%

Totals
Change from base Build 10350305634:	0.0%
Covered Lines:	542
Relevant Lines:	954

💛 - Coveralls

ogenstad commented 2 weeks ago

Is setuptools (https://github.com/nornir-automation/nornir/blob/main/pyproject.toml#L34) still required after this?

ktbyers commented 2 weeks ago

@ogenstad I am pretty sure we still need setuptools and as of Python 3.12 we have to explicitly include it as a dependency.