norsys / rothenberg

Rothenberg allows a developer to create or maintain a Symfony application or bundle very easily and without installing anything on his workstation.
Other
24 stars 14 forks source link

Check style = strange behavior. #9

Closed Axxon closed 6 years ago

Axxon commented 6 years ago

Hello, i tried to create my first commit on a rothenberg stacked project but the check-style-php returns is strange, example:

namespace AppBundle\Entity;
...
    /**
     * @param string $releaseId //l.28
     */
    public function __construct(string $releaseId)
    {
        $this->releaseId = $releaseId;
    }
...

Here the check-style output:

...
  28 | ERROR | Missing parameter comment
...

I have some other returns how look like this. So, finally i can't commit.

And:

FILE: /src/src/AppBundle/Entity/Item.php
----------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------

Why /src/src ?

cedvan commented 6 years ago

hi @Axxon,

src/src :

A comment php doc sample :

    /**
     * @param type variable comment
     */

Try :

    /**
     * @param string $releaseId my-super-comment
     */
Axxon commented 6 years ago

Thx @cedvan, ha ! That's a 'my-super-comment' required, so it's too much for me, i will disabled that's thing later. And i thinks this is also too much for a regular distribution rule, and the src/src is not user friendly (not explicit).