Currency units stop line from producing an output

nortakales / vs-code-qalc

Interactive scratchpad calculator for VS Code

MIT License

70 stars 2 forks source link

Currency units stop line from producing an output #32

Closed Ziraya closed 10 months ago

Ziraya commented 11 months ago

If I put a currency unit, USD in my case, in a line anywhere, in any form, that line no longer has an output.

5                               = 5
$5
5 $
$5 in EUR
5USD
5 USD
5 usd
5usd
5 USD
five = 5                        = 5
five USD
five km                         = 5 km

I have tried disabling qalc.currency.convertLocal, no effect

nortakales commented 10 months ago

The API I was using for exchange rates has just revoked free access. I can push a small change very quickly to at least restore $ and USD. I will need to find a new API that gets us as much free access as possible for the extension to restore actual conversions.

Ziraya commented 10 months ago

Thanks, got it. USD works, this is plenty for me.

$ isn't, not a big deal for me, I want my units after the value anyway.

I noticed that Qalc takes longer to start now, before it was about 12 seconds, now it's about 20~21 seconds. Could this be an API call timing out?

nortakales commented 10 months ago

I'm consistently getting around 14-15 seconds, which admittedly is pretty bad. I need to look into this. I'll open a new issue to track it.

nortakales commented 10 months ago

Currency and exchange rates should be fixed in 0.1.14