search

north-road / inasafe

InaSAFE - QGIS plugin for estimating impact from natural disasters
www.inasafe.org
GNU General Public License v3.0
0 stars 0 forks source link

Check minimum_needs discrepancies #15

Open elpaso opened 6 years ago

elpaso commented 6 years ago

Maybe due to zonal stats differenced in QGIS2 and 3

https://github.com/north-road/inasafe/commit/b1b821ea1d85a12d1ddc43c23e6b0816c25da0b6

elpaso commented 6 years ago

The attached spreadsheet contains qgis2 and qgis3 the pre-rounding values and the values after line https://github.com/north-road/inasafe/blob/nr-migration/safe/report/extractors/minimum_needs.py#L109

inasafe-qgis2-3-rounding.ods.zip

Please notice that the the values in the layer are already rounded for qgis3 but not for qgis2, that because I did some modifications https://github.com/north-road/inasafe/blob/nr-migration/safe/utilities/rounding.py#L42 in the rounding functions (to make another large number of tests to pass)

nyalldawson commented 6 years ago

I suspect this was partly due to the super-broken zonal stats calculator in 3.0 (up to recent 3.2 builds), but also because of underlying issues also present in 2.18 (which are now fixed in 3.2).