search

north-road / qgis-processing-r

QGIS Processing R Provider Plugin
https://north-road.github.io/qgis-processing-r/
GNU General Public License v3.0
63 stars 14 forks source link

Better capture errors from R in tool log #107

Closed JanCaha closed 2 years ago

JanCaha commented 2 years ago

This captures error lines from R that start with "Error: "and reports them correctly in tool log. These were previously skipped. This is kinda a standard R error message.

Also updates version in metadata and change log on website with latest changes.

@nyalldawson Can you please merge this and release this version? This will also allow us to close #105, but it was in previous pull request which I merged myself.

nyalldawson commented 2 years ago

@JanCaha

can you please merge this and release this version

sure -- i'll just wait for the conversation with @Gustry to be resolved

JanCaha commented 2 years ago

I accepted the changes by @Gustry. I didnt look at it much, since i did not change these files. But it is much better solution.

nyalldawson commented 2 years ago

@JanCaha want me to push out a release now?

JanCaha commented 2 years ago

Yes, that would be great :+1:

nyalldawson commented 2 years ago

@JanCaha done

agiudiceandrea commented 2 years ago

@JanCaha the version 3.1.1 changelog entry is missing from the plugin's metadata.txt file so it is not visible in the plugin manager and in the plugin repository. See https://github.com/qgis/QGIS/issues/47172 and https://plugins.qgis.org/plugins/processing_r/version/3.1.1/

JanCaha commented 2 years ago

Yeah a mistake on my part. I fixed it.