search

north-road / qgis-processing-r

QGIS Processing R Provider Plugin
https://north-road.github.io/qgis-processing-r/
GNU General Public License v3.0
63 stars 14 forks source link

Remove rgdal #126

Closed JanCaha closed 10 months ago

JanCaha commented 10 months ago

This is rather large change in the code, that reflects that R package rgdal has been retired from CRAN. Thus parts of the plugin are not usable anymore and actually cause issue with trying to install non existing package.

This should not be large problem, as this was quite heavily discussed in R community and the package was kind of obsolete anyways. Still this is quite likely to render some old scripts unusable and with need to be updated.

Some users would be able to run their old scripts if they have currently installed rgdal, but they will loose this option when upgrading their R version or reinstalling. For compatibility, older plugin versions can be used. But I believe that the latest version of the plugin should only support currently working R setup (which does not have rgdal at all).

@nyalldawson any issues with this? If not, could you please merge this and release the version to QGIS repository?

Fixes #125

nyalldawson commented 10 months ago

Thanks for doing this @JanCaha -- this is a fantastic job!

JanCaha commented 10 months ago

Added the QgsProcessingError if the unsupported commands are found, so it should be ready for release. @nyalldawson

nyalldawson commented 10 months ago

@JanCaha can I make you an admin for this plugin in the qgis repo? It seems silly for you not to have the ability to publish releases 😂

JanCaha commented 10 months ago

@nyalldawson feel free to do so :) User name is cahik at the plugins.qgis.org

nyalldawson commented 10 months ago

Ok, that's done! You're now official a plugin owner :)

Feel free to tag a release for this version!

JanCaha commented 10 months ago

Did and also pushed the release to QGIS plugins repository :)

nyalldawson commented 10 months ago

Thank you!!