search

north-road / qgis-processing-r

QGIS Processing R Provider Plugin
https://north-road.github.io/qgis-processing-r/
GNU General Public License v3.0
63 stars 14 forks source link

Help file reading issue (possibly upstream problem) #82

Closed JanCaha closed 3 years ago

JanCaha commented 3 years ago

Current problem causing tests to fail i.e. here caused by this test line seems to be an upstream issue. (Or it could be misunderstang of what should really happen.)

The problem, the way I undrestand, it is that if you load help file for algorithm it does not associate the help text with individual paramaters of the algorithm.

The help string works fine for whole algorithm but not for specific parameter.

It is probably not necessary to even test this, it would be quite ok to remove this part of test. But it seems to be worth knowing about as it might be upstream problem.

nyalldawson commented 3 years ago

It needs a patch which is in QGIS 3.16.4 or later (which is unreleased yet). We could conditionally skip this particular test on earlier versions...

JanCaha commented 3 years ago

Ok, should be fixed using #83.

Interesting is that it still fails with dev version (3.17.0-Master) .

Gustry commented 3 years ago 
QGIS version : 3.19.0-Master

FAIL: testAlgHelp (processing_r.test.test_algorithm.AlgorithmTest)
Test algorithm help
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/.local/share/QGIS/QGIS3/profiles/default/python/plugins/processing_r/test/test_algorithm.py", line 403, in testAlgHelp
    self.assertEqual(polyg_param.help(), 'A polygon layer')
AssertionError: '' != 'A polygon layer'
+ A polygon layer

Using the docker image qgis/qgis:latest so it still wrong indeed.