search

northem / northem-dark-atom-syntax

A north-bluish, dark clean and elegant Atom syntax theme.
MIT License
8 stars 2 forks source link

No support for MJML #2

Closed caseymhunt closed 8 years ago

caseymhunt commented 8 years ago

MJML files, which are, for the sake of argument, an extension of HTML syntax, are not supported by this theme.

arcticicestudio commented 8 years ago

Syntax Highlighting language is detected by the file extension, will add it as subtype to the HTML file. Is MJML 100% compatible to HTML or are there any differences or maybe additions I've to add? Nevertheless, I will bump the version so you can easly update the package and would appreciate feedback.

arcticicestudio commented 8 years ago

Released version 0.15.0 including MJML support.

caseymhunt commented 8 years ago

Excellent! I do not know of any specific support necessary for MJML but I will keep an eye out as I use the theme.

caseymhunt commented 8 years ago
screenshot 2016-02-15 16 53 01

Just some quick feedback- I really like this theme but I do suggest colorizing content between tags and attribute values differently. Being that they are both white, it is difficult to differentiate between tag content between and and element attributes. (Seen above)

This is particularly a problem with HTML (and subsequently, MJML).

arcticicestudio commented 8 years ago

This is one of the items on my backlog, but I am not conclusive about the color to use for the attribute values due to the limited colors of my Northem color palette. I don't want to change the color of text elements, but if I use the light-blue color for attributes it is difficult to see the difference between the attribute name and the value.

arcticicestudio commented 8 years ago

I've created a new issue [#3] to discuss about a improvement.