northem / northem-dark-atom-syntax

A north-bluish, dark clean and elegant Atom syntax theme.
MIT License
8 stars 2 forks source link

Improve colour differences for HTML/MJML #3

Closed arcticicestudio closed 8 years ago

arcticicestudio commented 8 years ago

Related to the comment of @caseymhunt in issue #2. The HTML/MJML color for attribute names and the associated value is hard to distinguish from the normal text content. github-atom-package-northem-dark-atom-syntax-issue-3-current

Possible solutions:

1) Attribute names are colored lime and the associated values are colored aqua, quoted string begin- and end symbols are blue

You can check out the improvement/ghi-3-testbranch-solution-1 test branch.

github-atom-package-northem-dark-atom-syntax-issue-3

2) Only change the quoted string begin- and end symbols to blue to mark better visualize the start and end of a attribute value. Normal text is not effected by this.

You can check out the improvement/ghi-3-testbranch-solution-2 test branch.

github-atom-package-northem-dark-atom-syntax-issue-3-solution-2

3) Only change the color of the attribute values to light-blue to differ from normal text.

You can check out the improvement/ghi-3-testbranch-solution-3 test branch.

github-atom-package-northem-dark-atom-syntax-issue-3-solution-3

3.1) In addition to solution 3, use bold font style for attribute names for better differentiation

You can check out the improvement/ghi-3-testbranch-solution-3.1 test branch.

github-atom-package-northem-dark-atom-syntax-issue-3-solution-3 1

3.2) This solution is a possible workaround to find a unified way for the PR [#4], please read the PR conversation for more information.
In addition to solution 3, use bold font style for tag names and underline attribute names for better differentiation

You can check out the improvement/ghi-3-testbranch-solution-3.2 test branch.

github-atom-package-northem-dark-atom-syntax-issue-3-solution-3 2

caseymhunt commented 8 years ago

I like this quite a bit- do you have a branch I can pull down and test this?

arcticicestudio commented 8 years ago

Updated the initial post, may add some more solutions. I will push some test branches tomorrow, it's late here, I have to get up early tomorrow for work ;)

arcticicestudio commented 8 years ago

Pushed test branches for all possible solutions, please read the updated the initial post for branch names.

arcticicestudio commented 8 years ago

I will stay with the solution 3.2 (improvement/ghi-3-testbranch-solution-3.2).

arcticicestudio commented 8 years ago

I've released version 0.16.0 which includes the merged solution.