search

northem / northem-dark-atom-syntax

A north-bluish, dark clean and elegant Atom syntax theme.
MIT License
8 stars 2 forks source link

Minor color suggestions. Indent guide color change. Padding for gutte… #4

Closed caseymhunt closed 8 years ago

caseymhunt commented 8 years ago

So far my preference for ease of reading is option 1. However, I still feel there needs to be a bit more differentiation. I've attempted to take a pass at it to show you what I mean. Feel free to do this correctly if you like the changes. I won't be offended at a denied pull request.

Color modifications:

arcticicestudio commented 8 years ago

Thanks for your effort to find a acceptable solution for all. Unfortunately, I must reject your PR due to some small disagreements, but will implement it partly.

  • bold and @dark-blue on entity tags to look a little more pronounced in a wall of code

I like the idea to use bold font for HTML tags to emphasize them better, but I will leave it blue instead of dark-blue. This way it won't look dimmed too much.

  • Indent guide lightened to be a little less distracting during writing

I also agree to this change, but this would lead to unvisible indent guide lines on the actual highlighted line, both colors would be light-coal (like you mentioned in bullet list item #3). I would like to change the color to coal for all lines which are not highlighted and only use light-coal for the actual line by seting a specific CSS rule for the cursor-line class selector, but it only works when the file gets loaded and does not update automatically. This way only the first selected line on file load would stay with loight-coal colored indent guide lines. To get this working i would have to write a script which updates on line change or integrate the already existing indent-guide-improved package, but this would blow up the package size and the definition of a "theme" package :pensive:

  • The gutter fold arrows were disappearing on line numbers over 3 digits. I've increased the space around these so they don't disappear.

I've tried to test this, but was not able to reproduce it :open_mouth: I've added lines up to 5 digits and the gutter dynamically adapts so the arrows won't disappear. Maybe you're running an outdated version (tested on Arch Linux with Atom 1.5.1) or there are conflicts with other packages modifing the behavior of the gutter.

For the better differentiation between the attribute name and the associated value I added a underline text decoration for the attribute name which works well together with the bold HTML tags and makes the attribute value very readable.

I have pushed another testbranch improvement/ghi-3-testbranch-solution-3.2 which includes all the changes I mentioned above and updated the issue [#3].

If you want to use the changes you made in this PR, you are free to add them to your personal styles.less stylesheet to override this part of my theme package to customize it. You can add the styles.less file to you atom home directory or create and edit it via Edit -> Open Your Stylesheet menu.

Here's a screenshot to preview my planned changes and would really appreciate some feedback to it :smile:

github-atom-package-northem-dark-atom-syntax-issue-3-solution-3 2

arcticicestudio commented 8 years ago

I will close this PR now and merge the testbranch improvement/ghi-3-testbranch-solution-3.2 which includes all the changes I mentioned above and in issue #3. Thanks anyway for your ideas and hope this solution is reasonable for you.