search

northem / northem-light-atom-ui

A north-bluish, light clean and elegant minimal Atom UI.
MIT License
1 stars 1 forks source link

Panels don't shade the whole UI #1

Closed edwardloveall closed 7 years ago

edwardloveall commented 7 years ago

Opening the fuzzy finder (or any other panel) doesn't shade the cover the whole workspace. The shade only extends 1.5em out from the edges of the fuzzy finder panel:

fuzzy finder shade

After playing around in the console for a second, if you remove this line is shades correctly.

I believe this is because when a parent element has relative positioning (as panels do in this theme) children with absolute positioning are relative to their parent. Weird, right?

Anyway, would you be opposed to a PR to fix this?

arcticicestudio commented 7 years ago

Thanks for your detailed report, this is really weird. Feel free to create a PR if you'd like to fix this, else I'll try to release a new version this weekend :smile: I also planned to do a general update for my Northem UI and Syntax themes to keep up with the latest Atom UI changes. Maybe this bug is caused by the new Pane API and/or layout API introduced in Atom 1.9, 1.10 and 1.11. Sadly i've neglected my Northem themes due to my new Nord themes which will also provide a light version in feature versions.

edwardloveall commented 7 years ago

Done! Great to know about planned updates. The fashion is definitely leaning toward dark themes these days, but I still love bright ones.

arcticicestudio commented 7 years ago

Merged your PR #2 into develop and will release a new version to APM tomorrow. Anyway, I decided to use my new Nord Atom UI theme as code base for my Northem Atom themes and adjust the colors of my Northem color palette to it. The Nord themes are up to date with the latest Atom changes and rewritten clean from scratch with a lot of improvements and features which would take too long to adapt into all my Northem themes.

I'll start the Northem rewrite as soon as I've implemented the custom theme settings for user feature for my Nord Atom UI theme which will include a option to switch to a bright Nord color style. This merge will mark the new code base for my Northem themes since then I only have to switch the color palettes :wink:

I would really appreciate some feedback about this idea. In the meantime you can check out my Nord Atom UI theme to see if you like the new style like e.g. the buttons, lists and so on. That's what this theme than will be look like, but colored using my Northem palette and of of course with a bright/light style :smile:

edwardloveall commented 7 years ago

Yeah I'll definitely check it out over the next couple of days. Is there a good place to give you feedback? I feel like github issue on a separate project isn't the place.

arcticicestudio commented 7 years ago

I'll create a tracking issue as soon as I start working on the rewrite and a related branch which can be tested for feedback. I'll add a mention to you to get you notified :wink: Also released version 0.4.1 some moments ago with your fix applied :smile: