northem / northem-light-atom-ui

A north-bluish, light clean and elegant minimal Atom UI.
MIT License
1 stars 1 forks source link

Deprecated selector in `northem-light-atom-ui/index.less` #12

Closed jaceee closed 7 years ago

jaceee commented 7 years ago

In northem-light-atom-ui/index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

arcticicestudio commented 7 years ago

Thanks for your report 👍

This is related to the change that elements are no longer encapsulated within a shadow DOM boundary which is a theme package API change announced some weeks ago. Atom will automatically convert the deprecated selectors so there should be no usage problems, the deprecation warning is a preparation only for package developers so they can update to the new API.

❗️ As soon as the changes of the newer Nord Atom UI package are merged these changes will be adopted to this package. You can read a more detailed information in arcticicestudio/nord#49 of the Nord Atom UI repository and in this issue comment related to the same deprecation report. ❗️

arcticicestudio commented 7 years ago

➡️ Continued and resolved in #19.

arcticicestudio commented 7 years ago

Duplicate of #19