northem / northem-light-atom-ui

A north-bluish, light clean and elegant minimal Atom UI.
MIT License
1 stars 1 forks source link

No visually difference of the active tab #6

Closed edwardloveall closed 7 years ago

edwardloveall commented 7 years ago

In #3 I gave the feedback that the current tab is hard to discern and @arcticicestudio agreed.

Possible solutions:

My preference would be for changing the background color like the theme currently does. That not only gives a feel of which tab is selected, but how wide each tab is. My eye can easily extrapolate the other tab widths because of this.

I actually really do enjoy the tab style that this theme currently has :)

arcticicestudio commented 7 years ago

I checked the code today and noticed that this is actually a bug. I implemented styles for it, but it gets overriden by an selector that sets specific rules for an MarkdownPreview tab.

arcticicestudio commented 7 years ago

Now using northem-light5 color for the current active tab which seem to fit with most syntax themes:

Northem Light Atom Syntax

One Light

Base16 Tomorrow Light

Solves related issue #7.

edwardloveall commented 7 years ago

Yeah! I think this helps a lot. Thank you.