search

northern-information / arcologies

an interactive environment for designing 2d sound arcologies with norns and grid
https://tyleretters.github.io/arcologies-docs
GNU General Public License v3.0
47 stars 7 forks source link

Add support for grayscale grid #3

Closed tgk closed 3 years ago

tgk commented 3 years ago

This adds support for grayscale grid as a configuration option.

I do not know if a grayscale grid can be detected through the Grid class. I did not see anything in the documentation indicating it was possible.

This is my first manipulation of parameter sets but I assume this will not break existing saved psets.

Tested on a grid 64 40h. I do not have a varibright device to test on.

tyleretters commented 3 years ago

((oh my gosh i'm so sorry i just saw this. my github notifications are still borked.))

two requests:

  1. can you change this to have grayscale be disabled by default?
  2. re-submit the PR against the dev branch

other than that looks good!! thank you for putting the time into this

tgk commented 3 years ago

So sorry for not picking this up - things have been busy and I no longer have a greyscale grid.

tyleretters commented 3 years ago

all good!! thanks for your contribution!!