search

northox / roundcube-yubikey-plugin

A plugin to use Yubico's Yubikey 2nd factor with Roundcube webmail
GNU General Public License v2.0
32 stars 6 forks source link

Uncaught Error: Call to undefined function Q() in yubikey_authentication.php:148 after updating Roundcubemail to 1.3.0 #17

Closed mercurytoxic closed 7 years ago

mercurytoxic commented 7 years ago

If I try to access settings in the server settings area I get this:

PHP Fatal error:  Uncaught Error: Call to undefined function Q() in /usr/share/webapps/roundcubemail/plugins/yubikey_authentication/yubikey_authentication.php:148                                                                                                                              
Stack trace:                                                                                                                                                                                                                                                                                                                               
#0 /usr/share/webapps/roundcubemail/program/lib/Roundcube/rcube_plugin_api.php(439): yubikey_authentication->preferences_list(Array)                                                                                                                                                                                                       
#1 /usr/share/webapps/roundcubemail/program/steps/settings/func.inc(1247): rcube_plugin_api->exec_hook('preferences_lis...', Array)                                                                                                                                                                                                        
#2 /usr/share/webapps/roundcubemail/program/steps/settings/edit_prefs.inc(28): rcmail_user_prefs('server')                                                                                                                                                                                                                                 
#3 /usr/share/webapps/roundcubemail/index.php(303): include_once('/usr/share/weba...')                                                                                                                                                                                                                                                     
#4 {main}
    thrown in /usr/share/webapps/roundcubemail/plugins/yubikey_authentication/yubikey_authentication.php on line 148

It seems that some functions are deprecated in the new Roundcube.

mercurytoxic commented 7 years ago

Here is a list of the deprecated functions: https://github.com/roundcube/roundcubemail/commit/6b2b2eca5fa48720c4e5b31b9aae200a185dfc0e

mercurytoxic commented 7 years ago

18 Replaced the deprecated functions and now it works again.

northox commented 7 years ago

I assumes #18 fixed it. Let me know if it's not the case. Thanks for the PR!