RC 1.3.8: multiple issues

northox / roundcube-yubikey-plugin

A plugin to use Yubico's Yubikey 2nd factor with Roundcube webmail

GNU General Public License v2.0

32 stars 6 forks source link

RC 1.3.8: multiple issues #24

Open corbolais opened 5 years ago

corbolais commented 5 years ago

Hi and thank you for the plugin.

Have been trying w/ RC 1.3.8, works OK-ish. So far so good.

However,

on every login-related page, the yubikey form is displayed. If using i.e. with twofactor_gauthenticator, the yubikey form is again displayed.
form field is named "roundcube_yubikey_plugin".
it would be quite nice to have some documentation or at least hints on how to avoid yubikeys API servers.

Cheers!

northox commented 5 years ago

I guess your latest pull request fixes the 2nd issue but not the other two. Can you clarify?

As for the last one, I believe it would be better to point people to Yubico’s documentation and the lines used to specify the servers URL (i.e. https://github.com/northox/roundcube-yubikey-plugin/blob/master/lib/Yubico.php#L160-L164). Or a pull request could move this list of URL to the user specified configuration (config.inc.php).

corbolais commented 5 years ago

Your assumption is correct, this PR fixes above issue No2.

I would handle above issue No1 together with repo issue #23, as it seems to fall into a similar category of restructuring that part of the code.

Or a pull request could move this list of URL to the user specified configuration (config.inc.php). This would be my personal favourite. Together with a reference/link to Y's docs and a local how to of sorts.

cheers