show_spinner_cmd was returning 0 regardless of what the command itself returned, which is bad since we rely on set -e to bail out whenever a command fails.
Also, stop ignoring shellcheck lint error SC2155. Makes for uglier code, but less painful debug.
Instead of:
# these raise no error
local foo=$(exit 1)
export bar=$(exit 1)
show_spinner_cmdwas returning0regardless of what the command itself returned, which is bad since we rely onset -eto bail out whenever a command fails.Also, stop ignoring shellcheck lint error SC2155. Makes for uglier code, but less painful debug.
Instead of:
Prefer:
or