search

northwesternfintech / ISA-Interview-Problems-Fall-2023

1 stars 0 forks source link

Formatting and best practices #1

Open andrlime opened 11 months ago

andrlime commented 11 months ago
  1. You didn't use logo.svg after importing it, might as well remove because it's pointless
  2. In background it was <div ... > with a space at the end and in foreground is was <div ...> with no space, this should probably be consistent otherwise it looks weird
  3. Component files should be capitalized, so background should be Background
echavemann commented 11 months ago

look at andrew caring about the applicant experience!!