nortikin / sverchok

Sverchok
http://nortikin.github.io/sverchok/
GNU General Public License v3.0
2.24k stars 233 forks source link

bug hunt: bevel node or remove doubles #1350

Closed zeffii closed 7 years ago

zeffii commented 7 years ago

image

https://gist.github.com/1f9c2105e021c8ac91594265a8965c22

ly29 commented 7 years ago

Bevel wraps the data one extra time causing remove doubles to fail.

ly29 commented 7 years ago

Spot the extra [ ] around each separate list object in the list comprehensions


        oV.sv_set([[i[0]] for i in out])
        if oE.is_linked:
            oE.sv_set([[i[1]] for i in out])
        if oP.is_linked:
            oP.sv_set([[i[2]] for i in out])

https://github.com/nortikin/sverchok/blob/master/nodes/modifier_change/bevel.py#L129-L133

zeffii commented 7 years ago

excellento, yes @ly29 . that processing func could be much shorter.. am tempted to redux it.

ly29 commented 7 years ago

I mostly want to go all pep8 over it.

ly29 commented 7 years ago

@zeffii I am working with javascript at the moment so some simple Sverchok bug hunting I can do in my sleep. So much subtle things going on in javascript...

zeffii commented 7 years ago

am suprised you haven't tried to build a webbased sverchok like tool already. sooner or later everything is emulated in js.

ly29 commented 7 years ago

not sverchok like at all, just really simple javascript things right now. (for real a minesweep clone to learn, very trivial but still so many things to deal with)

am tempted to do something like sverchok for the web, just to try, with webgl and obj export etc.

zeffii commented 7 years ago

js has become quite nice , arrow functions and all that es6/7/harmony whatever they call it now..

ly29 commented 7 years ago

the lambda syntax with arrows is one of things I wish they had done right in python.

zeffii commented 7 years ago

pushed.