ViewerDraw in b28 - Githubissues

zeffii commented 5 years ago

The current implementation ( VD_Experimental ) is a first attempt at using the new API/shader stuff. , and has helped debug the porting of nodes. It is quite limited in its current form, but might serve as a reference implementation for other openGL nodes in Sverchok.

I want to talk about implementing a VDMK2 port

javismiles commented 5 years ago

@zeffii , rendering single frames all good at any size, etc but I´ve tried to render the animation with Eevee, with cycles, with all, at all sizes, with different parameters, and it always crashes after 1 frame, should I raise an issue with Sverchok about this? feels like an issue with it maybe, as with blender 2.8 I´ve done way more complex animations with no issue, what do u think :)

javismiles commented 5 years ago

@zeffii , cause my initial reactions to the crashes when rendering animations were to blame memory issues but today after I solved the other issues I tried all sorts of different combinations and now I´m pretty convinced that it´s not a memory issue but a code issue, just not sure if its a code issue within Sverchok or in the interaction between Sverchok and blender 2.8, etc, because rendering single frames works at all times in all settings, and rendering animations fails at all times after frame 1 and in all sorts of settings, now I´m totally conscious that sverchok for blender 2.8 is still in development, but if I can help by reporting to the team this issue and helping to test it or etc let me know, I am now a super big fan of Sverchok, the best Blender add-on I have ever seen! amazing! :D so I´m happy to help if i can :) and hopefully we can find out why rendering animations crashes always after the first frame ooops, thank you again for your help ;)

zeffii commented 5 years ago

rendering animations is not something i've tested..
i would avoid updating the material on everyframe ( just as an experiment )

if you are outputting to BMesh Viewer then that's probably offtopic on this thread. It's OK to start a new thread about b28 crash during animation. (preferably with a downloadable .zip so i can just load and observe without having to do a setup first )

zeffii commented 5 years ago

it's not impossible that the most recent blender build has a bug, it is however not as likely as sverchok just doing something stupid (like triggering nodetree update event that sprials into an infinite loop upon frame change)

not likely a memory issue, especially if you can't make it ' not crash ' by passing it a simpler animation driven by sverchok.

javismiles commented 5 years ago

@zeffii thank you, so maybe if that part is not tested maybe its somewhere in there the issue, how could I test not to update the material on every keyframe? how is that done? will also look following your advice to open a new thread on b28 crash during animation

zeffii commented 5 years ago

just don't reference the material from the sverchok node tree. that way sverchok is not updating the material, and that update event in-turn will not cause sverchok to update (and send it down the spiral )

javismiles commented 5 years ago

@zeffii yes, I just did this test

I deleted the material from the sverchok bmesh node
I also disconnected the material from the normal shading nodes

so the shape renders totally black

and same crash happens and again exactly after first frame like always, same issue yeah, we gotta try something else

javismiles commented 5 years ago

@zeffii more useful info

BMesh Node

When disabling the LIVE button, no crash when rendering animation but no changes between frames, shape remains static of course!
When enabling LIVE button, Crash again when animating

obviously there is an issue in the BMesh node when it changes between frames

javismiles commented 5 years ago

@zeffii new test

I selected the BMesh object and deleted its material completely, Crash still happens after 1,2 frames seems clear an issue with BMesh node when changing from one frame to another within an animation

javismiles commented 5 years ago

@zeffii hopefully we can find where the issue is and fix it because BMesh I see it now as essential allowing me to do shading and render live changes of the shape each frame, VD Experimental is not useful for this as it will render when baked and remain static so BMesh is the way to do this

javismiles commented 5 years ago

opened issue at https://github.com/nortikin/sverchok/issues/2417

nortikin / sverchok

ViewerDraw in b28 #2372