Open portnov opened 5 years ago
https://github.com/nortikin/sverchok/blob/b28_prelease_master/docs/nodes/analyzers/intersect_plane_plane.rst https://github.com/nortikin/sverchok/blob/b28_prelease_master/docs/nodes/analyzers/intersect_line_sphere.rst https://github.com/nortikin/sverchok/blob/b28_prelease_master/docs/nodes/analyzers/deformation.rst https://github.com/nortikin/sverchok/blob/b28_prelease_master/docs/nodes/analyzers/distance_line_line.rst https://github.com/nortikin/sverchok/blob/b28_prelease_master/docs/nodes/analyzers/bbox_mk2.rst https://github.com/nortikin/sverchok/blob/b28_prelease_master/docs/nodes/analyzers/distance_line_line.rst and maybe others, they are there, what is the problem with them? and about pulga_phisics.rst. I was in the 2.7 branch... i missed it no i try to add it in #2622 and Travis throws a failure. The node is on the alpha category but on the modifiers_make folder. I placed the docs on the alpha folder. Did I miss anything?
Or maybe I should ignore this tests by the moment?
Most probable problems are
Aha, I see, under docs/
we have analyzers
(note the s), but under nodes/
we have analyzer
(without s)... probably there are other similar problems too.
@vicdoval you may add your node to known problems list (in the docs_tests.py
) for now if you wish.
There is just one fail in #2622 that probably is due the analyzer 's', Do you want me to change the folder name or ignore it and leave it to you?
I'll rename the directory.
Renamed in b28_prelease_master
.
@zeffii what should we do with alpha_nodes
and beta_nodes
? For other directories, there is 1-to-1 correspondence between directories under docs/nodes
and under nodes
; but we do not have nodes/alpha_nodes
or nodes/beta_nodes
. Should we remove corresponding directories from docs/nodes
? Or...?
@portnov i propose to drop those doc/directories .
I further propose the inclusion of some short-form documentation in the .py
of each node that doesn't have .rst
, maybe as a class property. Or maybe docstring extension..
node_doc = " some multi line info, formatted in some way that can be parsed "
class SvNodeName(....):
...
sv_shortform_doc = """ """ # node_doc
in which several things are made clear to the user
1. this node is not very well tested ( feel free to help and provide feedback at the issuetracker
2. known issues with the node (limitations, algorithm implementation details)
3. a link to the development thread(s) / pull request that spawn the node
4. a mention of the creators handle, optionally.
5. a date of node submit
6. what else?
I suspect few users take the time to read the docs, altho i think we provide a most convenient way to do so with the nodepanel / item / open documentation buttons
. Perhaps an additional spawnable panel from the Rclick menu of nodes could show a small popup of "Node Info".
I've dropped alpha_nodes
and beta_nodes
under docs
.
As for docstring... Well, ideally each node should have docstring, even those ones with documentation files — rst
file is user documentation, docstring is more for developers.
But, as you can see, there are many nodes without any documentation. If anyone has enough time to write either docstrings or regular documentation for them, you're welcome! :)
i'll do a proof of concept for vd_experimental , maybe :)
docstring is more for developers.
i agree, and also disagree. I am becoming a big proponent of not separating documentation that way.
the bpy py console is massively unutilized.
>>> nodes = bpy.data.node_groups['NodeTree'].nodes
>>> n = nodes['VD Experimental']
>>> help(n)
# 1. bla...
blablabla
# 2. blablabl
blablablablablabal
etc.
ascii schema
would be awesome.
but going off topic a little bit. i've been meaning to do some popup based documentation POC . this is good reason to do that today.
Technically, at sverchok loading time, we could read rst
documentation and do for node in nodes: node.__doc__ = read_rst_documentation(node)
:)
not sure if it would be that useful, though...
perhaps overwriting doc is a bit hardcore :)
>>> n.help
would be a reasonable SvNodeCommon solution
There are no corresponding
.rst
files for the following nodes:It is possible that for some of them the documentation actually exists, but file name differs. In that case documentation file should be renamed.