nortmas / chrome-bookmarks

Google Chrome bookmarks extension for the Ulauncher
17 stars 10 forks source link

Add "other" category to results #9

Closed sbeugen closed 3 years ago

sbeugen commented 3 years ago

Currently only "bookmark_bar" part of the bookmarks is considered when doing the lookup. Chrome also has the "other" category.

So the part of your code should look like follows. Current:

                data = json.load(data_file)
                bookmark_bar = data['roots']['bookmark_bar']
                matches = self.find_rec(bookmark_bar, query, matches)

Should be:

                data = json.load(data_file)
                bookmark_bar = data['roots']['bookmark_bar']
                other = data['roots']['other']
                self.find_rec(other, query, matches)
                matches = self.find_rec(bookmark_bar, query, matches)

If you want, I can also create a PR.

nortmas commented 3 years ago

Hi, I've deployed your change, yes feel free to create a PR. Sorry, currently I don't have much time to maintain it :(

sbeugen commented 3 years ago

Thx :+1:

nortmas commented 3 years ago

Code refatored. Issue fixed.