search

nortxort / pinylib

A rewrite of tinylib
MIT License
6 stars 3 forks source link

Redundant functions #27

Closed TechWhizZ199 closed 8 years ago

TechWhizZ199 commented 8 years ago

The function, at https://github.com/nortxort/pinylib/blob/master/rtmp/rtmp_protocol.py#L623, is no longer required if we handle it already at line https://github.com/nortxort/pinylib/blob/master/rtmp/rtmp_protocol.py#L517,

I this is also applicable to the handle_messages method if we already have a handle_packet method in rtmp_protocol.py .

nortxort commented 8 years ago

The reason i left it there was because i wasn't sure how this new way of doing it would work out. But as it turned out to be working just fine, we can now remove it yes. The handle_message method has to my knowledge never been used anywhere.

TechWhizZ199 commented 8 years ago

Sure, thank you Nort.