search

norvig / paip-lisp

Lisp code for the textbook "Paradigms of Artificial Intelligence Programming"
MIT License
7.18k stars 702 forks source link

Update chapters 4-6 #169

Closed ndvanforeest closed 2 years ago

ndvanforeest commented 2 years ago

typo

pronoiac commented 2 years ago

Looking good so far! Are you done with the chapter?

ndvanforeest commented 2 years ago

Actually, I found many more such small typos, but I did not know whether there would be any interest in repairing them. If so, I would be happy to contribute.

Sent from my iPad

On 11 Jun 2022, at 19:28, James Young @.***> wrote:

 Looking good so far! Are you done with the chapter?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

pronoiac commented 2 years ago

I'd love to see more typos corrected!

(I'd suggest a commit per chapter, or batch of typos, though.)

ndvanforeest commented 2 years ago

Sure. I'll continue with ch 4.

One thing surprised me. nil is sometimes between back tics, but not always. Is this on purpose? Likewise, should it be t, or just t, or T, or T?

On Sun, 12 Jun 2022 at 02:34, James Young @.***> wrote:

I'd love to see more typos corrected!

(I'd suggest a commit per chapter, or batch of typos, though.)

— Reply to this email directly, view it on GitHub https://github.com/norvig/paip-lisp/pull/169#issuecomment-1153030227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM266KBXS3XWLJZAE76H43VOUWDBANCNFSM5YPU4BJA . You are receiving this because you authored the thread.Message ID: @.***>

pronoiac commented 2 years ago

Good question! I don't have an articulate answer for that off-hand. @norvig, thoughts?

ndvanforeest commented 2 years ago

For the moment I focus on ch 6, hence it will take some time before I return to ch 4 and ch 5. If ok with you, please close this pr.

norvig commented 2 years ago

I think it should be t in tickmarks when discussing input; T when discussing output.

pronoiac commented 2 years ago

Too many (automated?) edits were accidentally included in the commit "tickmarks" - mostly whitespace edits. Some were good, like removing trailing spaces, some less so. I think I'm going to revert tabs to spaces (referencing the scan, I think it should be 8 spaces per tab?), and the eliza1.lisp edits. You don't need to do anything; I plan to include that work as I merge this.

Some notes on git: I'd suggest working from branches: git checkout -b tickmarks or the like, before you start editing. It makes it easier to juggle multiple angles of attack independently of each other.

I usually add to staging with git add -p , which lets me verify I'm intending only what I intend to add.

pronoiac commented 2 years ago

Merged!

ndvanforeest commented 2 years ago

Sorry for adding all the auto edits. I noticed there were white space changes, but then I used

git diff -w | git apply --cached --ignore-whitespace

to ignore them. Apparently this did not work. I'll check better next time.

On Fri, 24 Jun 2022 at 06:07, James Young @.***> wrote:

Merged!

— Reply to this email directly, view it on GitHub https://github.com/norvig/paip-lisp/pull/169#issuecomment-1165171257, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM266P3DUIFDIILMQ4H7OLVQUYARANCNFSM5YPU4BJA . You are receiving this because you authored the thread.Message ID: @.***>

pronoiac commented 2 years ago

Cool! Sorry it didn't work; glancing at the man pages, that looks like it ought to work? Dunno.