search

nos / client

The nOS Client
https://nos.io
MIT License
199 stars 73 forks source link

Reactify webview #8

Closed mhuggins closed 6 years ago

mhuggins commented 6 years ago

https://github.com/MarshallOfSound/react-electron-web-view

mhuggins commented 6 years ago

We shouldn't use this unless the repo owner merges https://github.com/MarshallOfSound/react-electron-web-view/pull/12 and pushes out a new version. Alternatively, we can just use the forked version from https://github.com/mhuggins/react-electron-web-view/tree/browserify-without-react.

mhuggins commented 6 years ago

The PR was merged, just need to wait for a new release now.

mhuggins commented 6 years ago

still waiting

DalderupMaurice commented 6 years ago

What's the status on this? -IF- we process with electron at all 😄 @mhuggins

DalderupMaurice commented 6 years ago

I see a new version is published here: https://github.com/MarshallOfSound/react-electron-web-view/releases/tag/v2.0.1

Although we'd have to wait for the evaluation of muon

mhuggins commented 6 years ago

@DalderupMaurice That's not a new version, that's from a year ago. We can just close this for now. It was a tiny nice-to-have, but not really necessary.

DalderupMaurice commented 6 years ago

Thought it was 2018 😂 Only looked at the day-months hahahaha