Template/react updated send function to avoid confusion - Githubissues

nos / create-nos-dapp

CLI tool to generate a new nOS dApp

53 stars 35 forks source link

Template/react updated send function to avoid confusion #24

Closed DalderupMaurice closed 6 years ago

DalderupMaurice commented 6 years ago

Description

renamed recipient to the receiver as this is this required name for the function

Apparantly I've also changed the readme 20 days ago and didn't create a PR for it lol

Motivation and Context

when sending assets the receiver was undefined even if you filled in the recipient. This was due to having the wrong name

How Has This Been Tested?

manually

Screenshots (if appropriate):

Types of changes

[x] Chore (tests, refactors, and fixes)
[ ] New feature (adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[x] I have read the CONTRIBUTING document.

Closing issues

Fixes #

mhuggins commented 6 years ago

Old habits die hard. Sorry I deleted your branch again. 😅