nos / create-nos-dapp

CLI tool to generate a new nOS dApp
53 stars 35 forks source link

chore(root): added circleci config #25

Closed DalderupMaurice closed 5 years ago

DalderupMaurice commented 6 years ago

Description

Updated 15-9-2018:

Circleci config is needed to for greenkeeper + CI

Notice the testing command - I'll add this in another PR (dropping this here for reference: https://glebbahmutov.com/blog/unit-testing-cli-programs/)

Motivation and Context

we need it!!

How Has This Been Tested?

👀

Screenshots (if appropriate):

Types of changes

Checklist:

Closing issues

Fixes #20

mhuggins commented 6 years ago

Just enabled this on Circle: https://circleci.com/gh/nos/create-nos-dapp

jeroenptrs commented 6 years ago

@DalderupMaurice how is this coming along?

DalderupMaurice commented 6 years ago

It's considered "done" wanted to add testing in a next PR :P

jeroenptrs commented 6 years ago

@DalderupMaurice could you include testing in this pull? I'm hesitant on merging something that returns a failed build check

DalderupMaurice commented 6 years ago

volkswagen FTW 😂 Was just about to continue this PR, including tests

jeroenptrs commented 6 years ago

@DalderupMaurice is there a possibility of keeping babel 7?

jeroenptrs commented 6 years ago

@DalderupMaurice can you please put babel 7 back in?

DalderupMaurice commented 5 years ago

done @jeroenptrs