search

nos / create-nos-dapp

CLI tool to generate a new nOS dApp
53 stars 35 forks source link

Init Angular 6 package #26

Closed mbtakanov closed 6 years ago

mbtakanov commented 6 years ago

Initial code for the Angular 6 package.

Description

Used angular-cli to create the package. All component tests are auto generated. All packages in the package.json file are from angular-cli except the @nosplatform and @cityofzion. The home page is the same as the react package.

Motivation and Context

Since there is only react package, this implementation is required in order to have variety of starter-kits.

How Has This Been Tested?

Used karma and e2e tests. Both are from the angular-cli.

DalderupMaurice commented 6 years ago

Testing the angular app under the nos:// protocol in the nOS client returns an error.

The actual error I got: The URL 'nos:0.0.0.0:4200/sockjs-node' is invalid I was told this was an issue with electron? The same we had with the react-app, right?

What are your thoughts? @mhuggins
How should we continue

mhuggins commented 6 years ago

It seems like the URL is missing the "//" after "nos:" in the sockjs-node path. @mbtakanov Is there a way to update the webpack config for angular? (Sorry, I'm not an angular guy.)

mbtakanov commented 6 years ago

Angular 5 is on the way. I will open a new PR when I'm done. In Angular 6, the webpack config cannot be ejected. This is the reason we will downgrade the version.

mbtakanov commented 6 years ago

Closing the PR. The new one with Angular 5 is here: https://github.com/nos/create-nos-dapp/pull/29