On Ubuntu, the "npm start" command won't compile without "sudo",

fmanea commented 6 years ago

So for users using Ubuntu, it would be more user friendly to know what to do to make it work from the first command, and not seak for help.

Also, an incomplete path to index.jsx appears on the demo page

It shows index.js, instead of index.jsx.

Signed-off-by: Flavian-Costin Manea maneaflavian@gmail.com

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Chore (tests, refactors, and fixes)
[ ] New feature (adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] I have read the CONTRIBUTING document.

Closing issues

Fixes #

jeroenptrs commented 6 years ago

@fmanea are you using nvm on linux/windows? https://docs.npmjs.com/getting-started/installing-node#using-a-version-manager-to-install-nodejs-and-npm

fmanea commented 6 years ago

After reading your link, it seemed that using nvm could solve the issue, I installed npm using sudo apt-get install npm Well, I guess that only the typo can be merged, should I do a separate pull request for it? Or maybe update the README.md to suggest using nvm. Best regards, Flavian

jeroenptrs commented 6 years ago

@fmanea yeah you can use this pull to suggest using nvm!

fmanea commented 6 years ago

@jeroenptrs I have added a new commit with the README.md change.

fmanea commented 6 years ago

I've made the required changes.

nos / create-nos-dapp