feat(api): externalize api bindings - Githubissues

nos / create-nos-dapp

CLI tool to generate a new nOS dApp

53 stars 35 forks source link

feat(api): externalize api bindings #6

Closed jeroenptrs closed 6 years ago

jeroenptrs commented 6 years ago

Moved API bindings to separate NPM package, this is now imported and in use.

Description

Changed API to include fallback functions
Externalized this to an npm package (@nosplatform/api-functions)
Implemented this in the starter kit

Motivation and Context

To make sure the functions aren't only usable in a React context, but can also be used in any other framework and Vanilla JS

How Has This Been Tested?

All actions are still functional, but externalized

Screenshots (if appropriate)

Not needed.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] My code follows the code style of this project.
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[x] I have read the CONTRIBUTING document.

Closing issues

Fixes #

jeroenptrs commented 6 years ago

Will open up the api-functions repo when docs are added 😂