Closed mhuggins closed 6 years ago
Disable HMR when running Parcel.
Electron cannot currently handle loading websockets when a custom protocol is used. We are not actively utilizing HMR from parcel regardless, which means we can safely disable it when running Parcel.
An electron bug has been filed: https://github.com/electron/electron/issues/12855
I ran the nOS client on the feat/nos-protocol branch and loaded the content at nos://localhost:1234 successfully.
feat/nos-protocol
nos://localhost:1234
N/A
Good work on the digging 😄 🥇
Description
Disable HMR when running Parcel.
Motivation and Context
Electron cannot currently handle loading websockets when a custom protocol is used. We are not actively utilizing HMR from parcel regardless, which means we can safely disable it when running Parcel.
An electron bug has been filed: https://github.com/electron/electron/issues/12855
How Has This Been Tested?
I ran the nOS client on the
feat/nos-protocol
branch and loaded the content atnos://localhost:1234
successfully.Screenshots (if appropriate):
Types of changes
Checklist:
Closing issues
N/A