nos / create-nos-dapp

CLI tool to generate a new nOS dApp
53 stars 35 forks source link

chore(build): serve parcel without HMR #8

Closed mhuggins closed 6 years ago

mhuggins commented 6 years ago

Description

Disable HMR when running Parcel.

Motivation and Context

Electron cannot currently handle loading websockets when a custom protocol is used. We are not actively utilizing HMR from parcel regardless, which means we can safely disable it when running Parcel.

An electron bug has been filed: https://github.com/electron/electron/issues/12855

How Has This Been Tested?

I ran the nOS client on the feat/nos-protocol branch and loaded the content at nos://localhost:1234 successfully.

Screenshots (if appropriate):

screen shot 2018-05-08 at 8 53 06 am

Types of changes

Checklist:

Closing issues

N/A

DalderupMaurice commented 6 years ago

Good work on the digging 😄 🥇