nosas / OmniToon

[WIP] ToonTown AI - Python Plays ToonTown
3 stars 0 forks source link

Remove hard-coded Factory method calls and (most) direct class instiations #97

Closed nosas closed 1 year ago

nosas commented 1 year ago

Future changes may include:

nosas commented 1 year ago

All tests passing, let's merge!

/projects/OmniToon(remove_hardcode)» pytest                                                                                                                                                                                                                                                                                                                                                                                   [19:55:30]
==================================================================================================================================================================================================================== test session starts =====================================================================================================================================================================================================================
platform darwin -- Python 3.10.9, pytest-7.3.0, pluggy-1.0.0
rootdir: /Users/sason/Documents/projects/OmniToon
collected 428 items                                                                                                                                                                                                                                                                                                                                                                                                                                          

tests/battle/test_battle_cog_creation.py ...................                                                                                                                                                                                                                                                                                                                                                                                           [  4%]
tests/battle/test_battle_creation.py ...........                                                                                                                                                                                                                                                                                                                                                                                                       [  7%]
tests/battle/test_battle_toon_creation.py ................                                                                                                                                                                                                                                                                                                                                                                                             [ 10%]
tests/battle/test_battle_toon_get_attacks.py ..............................................................................................................................                                                                                                                                                                                                                                                                            [ 40%]
tests/battle/test_reward_calculator.py ................................................................................................................................................................................................                                                                                                                                                                                                                [ 85%]
tests/cog/test_cog_creation.py ......                                                                                                                                                                                                                                                                                                                                                                                                                  [ 86%]
tests/entity/test_battle_entity_creation.py .......                                                                                                                                                                                                                                                                                                                                                                                                    [ 88%]
tests/entity/test_battle_entity_property.py ..............                                                                                                                                                                                                                                                                                                                                                                                             [ 91%]
tests/entity/test_entity_creation.py ....                                                                                                                                                                                                                                                                                                                                                                                                              [ 92%]
tests/entity/test_entity_property.py .                                                                                                                                                                                                                                                                                                                                                                                                                 [ 92%]
tests/gag/test_gag_creation.py ....................                                                                                                                                                                                                                                                                                                                                                                                                    [ 97%]
tests/inventory/test_inventory_creation.py ..                                                                                                                                                                                                                                                                                                                                                                                                          [ 97%]
tests/toon/test_toon_creation.py ..........                                                                                                                                                                                                                                                                                                                                                                                                            [100%]

==================================================================================================================================================================================================================== 428 passed in 0.35s =====================================================================================================================================================================================================================