search

nosco / hx

A simple, easy to use library for React development in ClojureScript.
MIT License
247 stars 16 forks source link

closure_uid keeps showing up in props created by goog.object #2

Closed lilactown closed 5 years ago

pepe commented 5 years ago

Sorry, I just found out, you are in the process of quite big refactoring. You can ignore this comment.

Hi. I am seeing it also. Do you think it can force to update components, even if the rendered DOM has not changed?

lilactown commented 5 years ago

😅 thanks for commenting though. Yeah, hoping to solve this in the refactoring.

lilactown commented 5 years ago

It looks like this was fixed in the refactoring I've done

pepe commented 5 years ago

It indeed was for me. Actually I am liking this library more and more. I event did some example project with it: hxor. It is right for usage with shadow-cljs.

Thanks man!

lilactown commented 5 years ago

Great! 😄 There are still a few things that I feel like I need to get right with it, but I'm glad you are enjoying it!

I took a look at your example project. I'd never heard of funcool/potok. It's pretty cool!

I noticed that you're calling hiccup/parse a couple times in component.cljs. Specifically here:

https://github.com/pepe/hxor/blob/master/src/hxor/components.cljs#L12

https://github.com/pepe/hxor/blob/master/src/hxor/components.cljs#L22

https://github.com/pepe/hxor/blob/master/src/hxor/components.cljs#L32

Those should not be necessary 😉. As long as the vectors are realized at runtime in the return value of defnc, then they will be interpreted correctly.

If that's not clear from the docs (or that actually isn't working), feel free to open up another issue!

pepe commented 5 years ago

Great! Thank you very much. I will fix it.

Potok is in my opinion the best way to handle the state of the app. And Beicon (RxJS wrapper in cljs, on which Potok is based) is of similar idea as hx, I believe.

pepe commented 5 years ago

It's fixed in hxor, thank you again.