search

nosco / hx

A simple, easy to use library for React development in ClojureScript.
MIT License
247 stars 16 forks source link

CI failed with incompatible module #27

Closed dawranliou closed 5 years ago

dawranliou commented 5 years ago

The last CI build failed with the error:

#!/bin/sh -eo pipefail
yarn install

yarn install v1.9.4
info No lockfile found.
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
error autobind-decorator@2.4.0: The engine "node" is incompatible with this module. Expected version ">=8.10".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Exited with code 1
dawranliou commented 5 years ago

Currently there's no test case setup yet. I think we can still use CI to build the workshop app, for example:

  1. Use npm to install the dependencies, instead of yarn.
  2. Do npm run release in the CI pipeline.

What do you think @Lokeh ?

lilactown commented 5 years ago

Yeah I started adding CI a few months ago and just never got around to finishing. Now it just spams my inbox everytime a commit gets made 😛

Building the workshop and deploying it to github pages or netlify or whatever could be cool.

lilactown commented 5 years ago

I've setup tests to run on CI now.

I'm not sure how helpful deploying the devcards would be for people.

Closing this for now.

dawranliou commented 5 years ago

Appreciate to look into this!